-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add latest upgrade infos #232
Conversation
Deploying registry-initiation-1 with Cloudflare Pages
|
Deploying registry-devnet with Cloudflare Pages
|
Deploying registry-testnet with Cloudflare Pages
|
WalkthroughThe pull request introduces updates to the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
testnets/initia/chain.json
(2 hunks)testnets/minievm/chain.json
(2 hunks)testnets/minimove/chain.json
(2 hunks)
🔇 Additional comments (5)
testnets/minimove/chain.json (2)
37-40
: LGTM: Binary URLs and version configuration
The binary URLs are correctly configured for all platforms and the version entry is properly structured with appropriate height progression (4062800 > 3544900).
Also applies to: 101-114
32-34
: Verify if v0.6.5 introduces breaking changes
The compatible_versions array only includes v0.6.5, suggesting this might be a breaking change from v0.6.4. Please ensure this is intentional and that upgrade documentation is available.
testnets/initia/chain.json (2)
41-44
: LGTM: Binary URLs and version configuration
The binary URLs are correctly configured for all platforms and the version entry is properly structured with appropriate height progression (2620000 > 1450000).
Also applies to: 92-105
36-38
: Verify if v0.6.4 introduces breaking changes
The compatible_versions array only includes v0.6.4, suggesting this might be a breaking change from v0.6.1. Please ensure this is intentional and that upgrade documentation is available.
✅ Verification successful
Breaking changes confirmed in v0.6.4
The GitHub release notes confirm that v0.6.4 introduces consensus breaking changes to address IBC async callback type mismatch. The single version in compatible_versions is correct and intentional due to these breaking changes.
- Breaking change: Allow string callback id (PR #315)
- Upgrade height: 2620000
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for upgrade documentation and breaking changes
echo "Checking for upgrade docs..."
fd -g "*UPGRADE*.md" -g "*MIGRATION*.md" -g "CHANGELOG.md"
Length of output: 286
Script:
#!/bin/bash
# Let's try a different approach to find upgrade docs and version info
echo "Searching for upgrade/migration docs..."
rg -i "upgrade|migration|breaking.?changes" -g "*.md"
echo -e "\nSearching for version v0.6.4 mentions..."
rg "v0\.6\.4" -A 3 -B 3
echo -e "\nSearching for version v0.6.1 mentions..."
rg "v0\.6\.1" -A 3 -B 3
Length of output: 9928
Script:
#!/bin/bash
# Let's check the GitHub releases for v0.6.4 to find any breaking changes
echo "Checking GitHub releases for v0.6.4..."
gh release view v0.6.4 -R initia-labs/initia
echo -e "\nChecking repository for any version upgrade notes..."
rg -i "upgrade.*(0\.6\.4|0\.6\.1)" --type md
Length of output: 1048
testnets/minievm/chain.json (1)
114-125
: LGTM: Version entry configuration
The version entry is properly structured with:
- Appropriate height progression (3370850 > 2882650)
- Both v0.6.7-1 and v0.6.7 listed as compatible versions, suggesting non-breaking changes
- Correct binary URLs pointing to v0.6.7-1
Summary by CodeRabbit
New Features
Bug Fixes